Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional tests regarding issues from the Trail of Bits audit of Balancer #506

Merged
merged 5 commits into from
Apr 5, 2022

Conversation

maltekliemann
Copy link
Contributor

No description provided.

@maltekliemann maltekliemann added the s:in-progress The pull requests is currently being worked on label Mar 28, 2022
@maltekliemann maltekliemann added this to the v0.3.1 milestone Mar 28, 2022
@maltekliemann maltekliemann self-assigned this Mar 28, 2022
`util::pool` raises if either `pool_amount` or `asset_amount` is zero.
This is an unfortunate result of the abstraction of `pool_join` and
`pool_exit` into `util::pool`, but it does protect the user from paying
for something they get nothing for.

The other four functions only raise an error if what the joining/exiting
user pays is zero. So this protects the LPs, but not the interacting
user.
@maltekliemann
Copy link
Contributor Author

Closes #485 (please refer to the comments there on how I judge the impact of each issue mentioned in the audit). See also #506 for a suggestion on how to test these types of issues in the future.

@maltekliemann maltekliemann added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Mar 28, 2022
@maltekliemann maltekliemann requested a review from sea212 March 28, 2022 20:31
@sea212
Copy link
Member

sea212 commented Apr 5, 2022

[...] See also #506 for a suggestion on how to test these types of issues in the future.

Was this meant to be a self-reference (into this PR) ?

@maltekliemann
Copy link
Contributor Author

@sea212 Oh, sorry. I meant #507.

@maltekliemann maltekliemann added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Apr 5, 2022
@maltekliemann maltekliemann merged commit 729be75 into zeitgeistpm:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants